Merge pull request #2970 from cvvergara/pumpup-to-alpha1

Creation of pgrouting version 4.0.0-alpha1

Author: cvvergara

.clang-tidy

@@ -0,0 +1,14 @@
+Checks: >
+    google-*,
+    -google-readability-casting,
+    clang-analyzer-*,
+    clang-diagnostic-*,
+    cppcoreguidelines-avoid-capturing-lambda-coroutines,
+    cppcoreguidelines-avoid-goto,
+    cppcoreguidelines-avoid-non-const-global-variables,
+    cppcoreguidelines-avoid-reference-coroutine-parameters
+
+WarningsAsErrors: ''
+HeaderFilterRegex: './include'
+FormatStyle:     none
+InheritParentConfig: true

.github/scripts/tidy-vs-commit.sh

@@ -20,14 +20,13 @@
 # ------------------------------------------------------------------------------
 
 
-
 DIR=$(git rev-parse --show-toplevel)
 
 pushd "${DIR}" > /dev/null || exit 1
 
 mkdir -p build
 pushd build > /dev/null || exit 1
-cmake -DWITH_DOC=ON -DCMAKE_BUILD_TYPE=Release -DLOCALE=ON ..
+cmake -DBUILD_HTML=OFF -DBUILD_LOCALE=ON ..
 
 make locale
 popd > /dev/null || exit 1
@@ -39,7 +38,9 @@ perl -ne '/\/en\// && print' build/doc/locale_changes_po.txt | \
     perl -pe 's/(.*)en\/LC_MESSAGES(.*)/$1pot$2t/' >> build/doc/locale_changes_po_pot.txt  # .pot files
 
 # Remove obsolete entries #~ from .po files
-bash tools/transifex/remove_obsolete_entries.sh
+find locale -type f -name '*.po' -exec sh -c '
+    msgattrib --no-obsolete -o "$f" "$f"
+  ' sh {} \;
 
 while read -r f; do git add "$f"; done < build/doc/locale_changes_po_pot.txt
 

tools/transifex/update_locale.sh renamed to .github/scripts/update_locale.sh

@@ -36,21 +36,19 @@ on:
       - 'include/**'
       - 'pgtap/**'
       - 'tools/testers/**'
-      - './CMakeLists.txt'
+      - 'CMakeLists.txt'
 
     branches-ignore:
       - 'gh-pages'
 
-    tags: []
-
   pull_request:
     paths:
       - '.github/workflows/boost_version.yml'
       - 'src/**'
       - 'include/**'
       - 'pgtap/**'
       - 'tools/testers/**'
-      - './CMakeLists.txt'
+      - 'CMakeLists.txt'
 
     branches-ignore:
       - 'gh-pages'
@@ -131,5 +129,5 @@ jobs:
           sudo service postgresql start
           psql -c "CREATE DATABASE ___pgr___test___;"
           DIR=$(git rev-parse --show-toplevel)
-          bash "${DIR}/tools/testers/setup_db.sh" "${PGPORT}" ___pgr___test___ "${PG_RUNNER_USER}" "3.8.0"
+          bash "${DIR}/tools/testers/setup_db.sh" "${PGPORT}" ___pgr___test___ "${PG_RUNNER_USER}" "4.0.0"
           pg_prove  -Q -f --normalize --directives --recurse -U "${PG_RUNNER_USER}" -d ___pgr___test___ "pgtap"

.github/workflows/boost_version.yml

@@ -12,7 +12,7 @@ on:
       - 'include/**'
       - 'pgtap/**'
       - 'tools/testers/**'
-      - './CMakeLists.txt'
+      - 'CMakeLists.txt'
 
     branches-ignore:
       - 'gh-pages'

.github/workflows/centos.yml

@@ -63,7 +63,7 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v5
-      - name: Install Requirements
+      - name: Checkout cpplint
         uses: actions/checkout@v5
         with:
           repository: 'cpplint/cpplint'

.github/workflows/check-files.yml

@@ -26,8 +26,6 @@ on:
     branches-ignore:
       - 'gh-pages'
 
-    tags: []
-
   pull_request:
     paths:
       - '.github/workflows/check-queries.yml'
@@ -50,7 +48,7 @@ permissions:
 
 jobs:
   build:
-    name: Check queries
+    name: Build
     runs-on: ubuntu-latest
 
     strategy:
@@ -78,6 +76,7 @@ jobs:
         run: |
           sudo apt-get update
           sudo apt-get install -y \
+            doxygen graphviz \
             libboost-graph-dev \
             libtap-parser-sourcehandler-pgtap-perl \
             postgresql-${PGVER} \
@@ -91,7 +90,7 @@ jobs:
           export PATH=/usr/lib/postgresql/${PGVER}/bin:$PATH
           mkdir build
           cd build
-          cmake -DPOSTGRESQL_VERSION=${PGVER} -DCMAKE_BUILD_TYPE=Debug ..
+          cmake -DPOSTGRESQL_VERSION=${PGVER} -DCMAKE_BUILD_TYPE=Debug -DBUILD_DOXY=ON ..
 
       - name: Build
         run: |
@@ -121,3 +120,11 @@ jobs:
           done
 
           ./tools/testers/doc_queries_generator.pl -pgver "${PGVER}"
+
+      - name: Check Developers Documentation
+        run: |
+          cd build
+          make doxy
+          more DOXYLOG
+          [ ! -s DOXYLOG ] || echo "There are Doxygen warnings"
+          [ ! -s DOXYLOG ] || exit 1

.github/workflows/check-queries.yml

@@ -19,21 +19,19 @@ on:
       - 'include/**'
       - 'pgtap/**'
       - 'tools/testers/**'
-      - './CMakeLists.txt'
+      - 'CMakeLists.txt'
 
     branches-ignore:
       - 'gh-pages'
 
-    tags: []
-
   pull_request:
     paths:
       - '.github/workflows/clang.yml'
       - 'src/**'
       - 'include/**'
       - 'pgtap/**'
       - 'tools/testers/**'
-      - './CMakeLists.txt'
+      - 'CMakeLists.txt'
 
     branches-ignore:
       - 'gh-pages'
@@ -48,10 +46,13 @@ permissions:
 jobs:
   Test_clang:
     name: Ubuntu clang
-    runs-on: ubuntu-latest
+    runs-on: ${{ matrix.os }}
 
     strategy:
         fail-fast: false
+        matrix:
+          release: [Debug, Release]
+          os: [ubuntu-latest, ubuntu-22.04]
 
     steps:
       - uses: actions/checkout@v5
@@ -64,12 +65,21 @@ jobs:
           echo "PGIS=3" >> $GITHUB_ENV
           echo "PGPORT=5432" >> $GITHUB_ENV
 
+      - name: 'Raise Priority for apt.postgresql.org'
+        run: |
+          cat << EOF >> ./pgdg.pref
+          Package: *
+          Pin: release o=apt.postgresql.org
+          Pin-Priority: 600
+          EOF
+          sudo mv ./pgdg.pref /etc/apt/preferences.d/
+          sudo apt update
+
       - name: Add PostgreSQL APT repository
         run: |
-          sudo apt-get install curl ca-certificates gnupg
-          curl https://www.postgresql.org/media/keys/ACCC4CF8.asc | sudo apt-key add -
-          sudo sh -c 'echo "deb http://apt.postgresql.org/pub/repos/apt/ \
-            $(lsb_release -cs)-pgdg main" > /etc/apt/sources.list.d/pgdg.list'
+          sudo apt-get -y purge postgresql-*
+          sudo sh -c 'echo "deb http://apt.postgresql.org/pub/repos/apt $(lsb_release -cs)-pgdg-testing main ${PGVER}" > /etc/apt/sources.list.d/pgdg.list'
+          curl https://www.postgresql.org/media/keys/ACCC4CF8.asc | gpg --dearmor | sudo tee /etc/apt/trusted.gpg.d/apt.postgresql.org.gpg >/dev/null
 
       - name: Install dependencies
         run: |
@@ -84,12 +94,14 @@ jobs:
             postgresql-${PGVER}-postgis-${PGIS}-scripts \
             postgresql-server-dev-${PGVER}
 
-      - name: Configure
+      - name: Configure for clang
         run: |
           export PATH=/usr/lib/postgresql/${PGVER}/bin:$PATH
           mkdir build
           cd build
-          CXX=clang++ CC=clang cmake -DPOSTGRESQL_VERSION=${PGVER} -DCMAKE_BUILD_TYPE=Debug -DWITH_DOC=OFF ..
+          CXX=clang++ CC=clang cmake -DPOSTGRESQL_VERSION=${PGVER} \
+             -DCMAKE_BUILD_TYPE=${{ matrix.release }} -DBUILD_HTML=OFF -DBUILD_DOXY=OFF \
+             -DUSE_CLANG_TIDY=ON ..
 
       - name: Build
         run: |

.github/workflows/clang.yml

@@ -25,8 +25,6 @@ on:
     branches-ignore:
       - 'gh-pages'
 
-    tags: []
-
   pull_request:
     paths:
       - '.github/workflows/doc-check.yml'
@@ -52,7 +50,7 @@ jobs:
     strategy:
         fail-fast: false
         matrix:
-          language: [en,es,zh_Hans]
+          language: [en, es, zh_Hans, sv]
 
     steps:
       - uses: actions/checkout@v5
@@ -62,7 +60,7 @@ jobs:
       - name: check modified files
         id: check_files
         run: |
-          # allways processing english, no matter what the change was
+          # always processing english, no matter what the change was
           if [[ "${{ matrix.language }}" == "en" ]]; then echo "PROCESS=true" >> $GITHUB_ENV; exit 0; fi
 
           # when this file changes  all languages are tested
@@ -103,38 +101,28 @@ jobs:
           sudo apt-get update
           sudo apt-get install -y \
             libboost-graph-dev \
+            python3-sphinx \
+            python3-sphinx-bootstrap-theme \
             postgresql-${PGVER} \
             postgresql-server-dev-${PGVER} \
-            graphviz \
-            doxygen
-          python -m pip install --upgrade pip
-          pip install -r requirements.txt
-          pip list
-
+            graphviz
 
       - name: Configure
         if: env.PROCESS == 'true'
         run: |
           export PATH=/usr/lib/postgresql/${PGVER}/bin:$PATH
           mkdir build
           cd build
-          cmake -DLINKCHECK=ON -DWITH_DOC=ON \
-                -DES=ON -DZH_HANS=ON -DBUILD_DOXY=ON \
-                -DPOSTGRESQL_VERSION=${PGVER} -DCMAKE_BUILD_TYPE=Release ..
+          cmake -DBUILD_LINKCHECK=ON \
+                -DSPHINX_FLAGS='-W -v -j auto --keep-going' \
+                -DPOSTGRESQL_VERSION=${PGVER} ..
 
       - name: Check Documentation
         if: env.PROCESS == 'true'
         run: |
           cd build
           make html-${{ matrix.language }}
 
-      - name: Check Developers Documentation
-        if: env.PROCESS == 'true'
-        run: |
-          cd build
-          make doxy
-          [ ! -s build/doxygen/LOG ] || exit 1
-
       - name: Check Links
         if: env.CHK_LINK == 'true'
         run: |

.github/workflows/doc-check.yml

@@ -12,21 +12,19 @@ on:
       - 'include/**'
       - 'pgtap/**'
       - 'tools/testers/**'
-      - './CMakeLists.txt'
+      - 'CMakeLists.txt'
 
     branches-ignore:
       - 'gh-pages'
 
-    tags: []
-
   pull_request:
     paths:
       - '.github/workflows/macos.yml'
       - 'src/**'
       - 'include/**'
       - 'pgtap/**'
       - 'tools/testers/**'
-      - './CMakeLists.txt'
+      - 'CMakeLists.txt'
 
     branches-ignore:
       - 'gh-pages'