From f49e16fc44b7fc4f4025841bc26001e7b6e8fec0 Mon Sep 17 00:00:00 2001 From: Orion Poplawski Date: Fri, 22 Dec 2023 18:44:41 -0700 Subject: [PATCH] [pfsense_inferface_group] Check that members list is unique --- plugins/module_utils/interface_group.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/plugins/module_utils/interface_group.py b/plugins/module_utils/interface_group.py index aaeb0f47..bffd4b07 100644 --- a/plugins/module_utils/interface_group.py +++ b/plugins/module_utils/interface_group.py @@ -77,6 +77,9 @@ def _validate_params(self): self.module.fail_json(msg='Group name cannot have more than 15 characters.') if re.match('[0-9]$', params['name']) is not None: self.module.fail_json(msg='Group name cannot end with a digit.') + # Make sure list of interfaces is a unique set + if len(params['members']) > len(set(params['members'])): + self.module.fail_json(msg='List of members is not unique.') # TODO - check that name isn't in use by any interfaces ##############################