Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update isort dependency to the latest version #46

Open
RyutaroHashimoto opened this issue Mar 4, 2024 · 3 comments
Open

Update isort dependency to the latest version #46

RyutaroHashimoto opened this issue Mar 4, 2024 · 3 comments

Comments

@RyutaroHashimoto
Copy link

Pysen only supports older versions of isort.

pysen/setup.py

Line 49 in f969467

"isort>=4.3,<5.2.0",

@linshokaku
Copy link
Member

The versions specified here are ones confirmed to work with pysen.
They also form part of the standardization provided by pysen.
In many cases, you may need to use higher versions, in which case we recommend specifying versions individually.
cf. https://github.com/pfnet/pysen?tab=readme-ov-file#what-isnt-pysen

@RyutaroHashimoto
Copy link
Author

Thank you for your response.
In our project, we're using Poetry for module management, and I'm currently facing issues with using the latest versions of mypy and isort.
Could you please help me update the required versions in this section?

pysen/setup.py

Lines 44 to 51 in f969467

extras_require={
"lint": [
"black>=19.10b0,<=22.10",
"flake8-bugbear", # flake8 doesn't have a dependency for bugbear plugin
"flake8>=3.7,<5",
"isort>=4.3,<5.2.0",
"mypy>=0.770,<0.800",
],
"

@linshokaku
Copy link
Member

Is extras=["lint"] specified in the pysen entry of pyproject.toml, which manages dependencies by poetry? If you want to specify your own version of linter, need to remove this specification.
cf. https://github.com/pfnet/pysen?tab=readme-ov-file#install-pysen-with-your-choice-of-linter-versions

If possible, please provide the following information to help us solve the problem.

  • poetry config (pyproject.toml)
  • poetry version
  • python version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants