Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove post_install.bash #19

Open
1 task
mihaimorariu opened this issue Aug 18, 2021 · 0 comments
Open
1 task

Remove post_install.bash #19

mihaimorariu opened this issue Aug 18, 2021 · 0 comments
Labels
normal priority Normal priority items size-XS Very small item (a few hours to 1-2 days of work)

Comments

@mihaimorariu
Copy link
Contributor

The installation procedure currently requires running the post_install.bash script in order to install torchsearchsorted and torch_scatter. These dependencies should be added to setup.py instead, allowing users to install PyNIF3D simply via pip install -e . The only reason why the post installation script exists is because PyNIF3D has not yet been tested with the newer versions of the two dependencies.

Tasks to be completed

  • TODO

Definition of Done
A clear and concise description of the conditions for marking the issue as completed.
@mihaimorariu mihaimorariu added normal priority Normal priority items size-XS Very small item (a few hours to 1-2 days of work) labels Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
normal priority Normal priority items size-XS Very small item (a few hours to 1-2 days of work)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mihaimorariu