-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't download the full svf #92
Comments
Same issue here - has there been any fixed implemented for this. We used to use an old version for this but it no longer works as it mentions the oauth being deprecated? |
this update has completely broken our workflow - does anyone have a solution for this? i haven't been able to find anything to get around it at present. We cannot download SVF assets following conversion. same issue as the images above (could not download asset) - all it outputs is an output.svf with no assets. |
Thanks for the heads up. Looks like the svf file itself is still downloaded and parsed successfully but something is affecting the subsequent downloads of the referenced assets. Let me look into that. |
I've just tried downloading a couple of SVFs, and they all succeeded. I even tried re-translating the designs into SVF1 from scratch, but still could not reproduce the issue. Could you please provide more details? What file format is this happening for? What are the exact repro steps? |
Hi petr,
Thanks for getting back to me.
I’ve tried many ways and the issue is occurring on a fresh APS setup. Converting to SVF1 / 2 on a new bucket is causing issues with export.
Uploading RVT (2022) to a bucket, then translating the file (usually SVF1 for comparability) and then downloading the file to a fresh folder usually worked without any issues.
I have had this issue for a few months and found an older version of the visual studio extension worked but it now lists it as deprecated when attemptinf to use it. Updating to any later versions I see this issue.
I imagine it has something to do with the oauth2 updates in April but as far as I am aware on our end it’s all upto date and that’s what we are operating under as part of our setup (especially when setting up a new API in our login)
Any help would be greatly appreciated!
On 6 Aug 2024, at 5:51 PM, Petr Broz ***@***.***> wrote:
I've just tried downloading a couple of SVFs, and they all succeeded. I even tried re-translating the designs into SVF1 from scratch, but still could not reproduce the issue. Could you please provide more details? What file format is this happening for? What are the exact repro steps?
—
Reply to this email directly, view it on GitHub<#92 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A5CWXEU2NDNKAEEQXNAA233ZQB6ABAVCNFSM6AAAAABJ3FFOAOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZQGYYTIOBTHE>.
You are receiving this because you commented.Message ID: ***@***.***>
|
Thanks for the details! Couple of notes:
|
Hi Petr,
That’s right we have been successfully using SVF files for some time now for using our models offline.
I have attached some screenshots of our usual process:
***@***.***
Upload a .rvt to a bucket
***@***.***
Translate (Custom) the revit file to SVF.
***@***.***
Once the translation is complete we then have access to a viewable model right in visual studio which works fine and can be viewed.
***@***.***
From there we would then try right click to download object derivatives as SVF but will run into the same issue as @delundgren<https://github.com/delundgren> in that no output will occur for the supporting files besides the output.svf – which is unusable as its missing all assets for the model (including materials)
I hope this helps!
From: Petr Broz ***@***.***>
Sent: Tuesday, August 6, 2024 7:24 PM
To: petrbroz/vscode-forge-tools ***@***.***>
Cc: STABL ***@***.***>; Mention ***@***.***>
Subject: Re: [petrbroz/vscode-forge-tools] Can't download the full svf (Issue #92)
Thanks for the details! Couple of notes:
* please note that the download feature only works for SVF1, not SVF2
* this doesn't seem to be related to authentication; whether it's downloading the svf file itself or one of its referenced assets, the code calls the same Model Derivative endpoint with the same authentication, and from your description it sounds like you are able to download the svf file
* I've just noticed in the screenshot provided by @delundgren<https://github.com/delundgren> that they're actually attempting to download the SVF generated from a DWG file; what error exactly are you getting @STABLENG<https://github.com/STABLENG>?
—
Reply to this email directly, view it on GitHub<#92 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A5CWXEVQQ43BHNNJNYRR7FLZQCI4RAVCNFSM6AAAAABJ3FFOAOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZQHAYTANJZGM>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
I've just published a new version of the extension (2.7.0) that will output more debugging information into its own output channel. If you can still reproduce the issue as @delundgren (getting a "could not download asset" error), please check the log to see if there's any more details. |
@petrbroz - I just updated the extension and attempted to download again. Here's the terminal logging: |
@petrbroz<https://github.com/petrbroz> – I have updated the extension and tried it on a fresh set up (tried with a trial account, fresh application creation and environment and a fresh bucket set up)
and get the same error code and terminal as before with it not being able to download the assets despite saying it succeeded.
Have ensured 3 legged authentication is working also with the correct call back.
From: Dale Lundgren ***@***.***>
Sent: Wednesday, August 7, 2024 4:46 AM
To: petrbroz/vscode-forge-tools ***@***.***>
Cc: STABL ***@***.***>; Mention ***@***.***>
Subject: Re: [petrbroz/vscode-forge-tools] Can't download the full svf (Issue #92)
@petrbroz<https://github.com/petrbroz> - I just updated the extension and attempted to download again. Here's the terminal logging:
image.png (view on web)<https://github.com/user-attachments/assets/f6dbc3b8-2a53-40d0-9df9-56add04ef923>
—
Reply to this email directly, view it on GitHub<#92 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A5CWXERZM6OLRZX7B2G6PWDZQEKVZAVCNFSM6AAAAABJ3FFOAOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZRHEZDKNBTHE>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
|
Thanks guys. I've narrowed the issue down to the following piece of code in svf-utils: https://github.com/petrbroz/svf-utils/blob/develop/src/svf/downloader.ts#L100-L112 By default, when there's missing files in the SVF, the downloader only reports this in the console instead of throwing an exception. This can be modified by setting the Since I still can't reproduce the issue locally, I've put together a quick Node.js script that will try and download the SVF with the |
Hi Petr,
I managed to get it to output the file with a generated access code but the problem persists unfortunately.
It downloaded only the “output.svf” to my selected folder like when using the extension:
***@***.***
Not a huge expert with visual studio so let me know if theres a way to dump my entire console.
From: Petr Broz ***@***.***>
Sent: Wednesday, August 7, 2024 5:43 PM
To: petrbroz/vscode-forge-tools ***@***.***>
Cc: STABL ***@***.***>; Mention ***@***.***>
Subject: Re: [petrbroz/vscode-forge-tools] Can't download the full svf (Issue #92)
Thanks guys. I've narrowed the issue down to the following piece of code in svf-utils:
https://github.com/petrbroz/svf-utils/blob/develop/src/svf/downloader.ts#L100-L112
By default, when there's missing files in the SVF, the downloader only reports this in the console instead of throwing an exception. This can be modified by setting the failOnMissingAssets property to true.
Since I still can't reproduce the issue locally, I've put together a quick Node.js script that will try and download the SVF with the failOnMissingAssets option set: https://gist.github.com/petrbroz/596879789976e7499a8b6400ae615e8d. Could you please try and download your SVFs with this script, and share the console logs?
—
Reply to this email directly, view it on GitHub<#92 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A5CWXEVD3XPDJPSLFK4Q5VTZQHFZ3AVCNFSM6AAAAABJ3FFOAOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZSHAZDSOJXGI>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
|
@STABLENG you can simply run the |
Thank you @STABLENG. Btw I've deleted your last message as it contained sensitive information (an access token). Let me investigate the error logs, and I'll get back to you. |
Ok, so I've tested the urn and the access token you shared, and I was actually able to download the entire SVF using the same node.js script... are you perhaps behind some firewall that could be interfering with the outgoing requests? Could you try and run the script on another machine? |
Thanks for deleting the message ill ensure I do a clean up of the access token / URN later
I have just tried it on 2 different networks then the one I was using earlier today (including a phone hotspot) and have set it up on a totally different computer just now and the same issue persists on both. I also turned off windows firewall etc. to test.
Is there any way to confirm trusted extensions etc. similar to how opening files in visual studio code asks if you trust authors when accessing files?
From: Petr Broz ***@***.***>
Sent: Wednesday, August 7, 2024 6:57 PM
To: petrbroz/vscode-forge-tools ***@***.***>
Cc: STABL ***@***.***>; Mention ***@***.***>
Subject: Re: [petrbroz/vscode-forge-tools] Can't download the full svf (Issue #92)
Ok, so I've tested the urn and the access token you shared, and I was actually able to download the entire SVF using the same node.js script... are you perhaps behind some firewall that could be interfering with the outgoing requests? Could you try and run the script on another machine?
-
Reply to this email directly, view it on GitHub<#92 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A5CWXEWT7SERJVOZFS6UXZLZQHONLAVCNFSM6AAAAABJ3FFOAOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZSHE3DQNJVGQ>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
|
Hi Petr, Here's my result: //failOnMissingAssets: true PS C:\Users\dalel\source\repos\SVFDownloadTest> node download.js |
Hi Petr, A bit of an update. Whilst i couldn't get it to work on any windows computer i have (including trying on different networks) i did finally manage to get it to download my files on the mac version of Visual Studio Code without any issues. Whilst its a good to have a solution for us to continue using the platform i am still not sure what has changed to block the downloads on our end? I have tried reinstalling VSCode, turning off firewall / windows defender etc. to no avail. I am not sure if something has changed in VS Code itself because as i mentioned this was working on an older version of the extension because i was having the same issue with this months ago. Just until just a few weeks ago it was working until the older version of the extension started listing as deprecated whilst trying to initiate the download which caused me to update. Appreciate your help so far and not sure on the solution for Windows moving forward. |
Hi guys, @STABLENG you're right, it turned out to be an issue that only appeared on Windows systems. A new version of the vscode extension (2.7.1) has just been released where this issue has been addressed. Please give it a try, and if the issue persists, let me know. |
@petrbroz I just tested the new version (on Windows) and it is working as expected. Thank you! |
Thanks Petr, Got around to testing and can confirm the Windows version is working great now. Thanks for getting this fixed! |
Hi, when I download the svf packet, there is only one output.svf file downloaded, I can't find any other files. May I know what I should do?
The text was updated successfully, but these errors were encountered: