Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hgo641
approved these changes
May 3, 2024
| @@ -0,0 +1,10 @@ | |||
| package com.petqua.common.util | |||
|
|
|||
| inline fun <reified K, V> Map<K, V>.getOrThrow( | |||
Combi153
reviewed
May 3, 2024
Comment on lines
+571
to
+575
| Given("주문 내역을 조회 할 때") { | ||
| val accessToken = signInAsMember().accessToken | ||
| val memberId = getMemberIdByAccessToken(accessToken) | ||
|
|
||
| val storeA = storeRepository.save( |
Comment on lines
+163
to
+167
| @Schema( | ||
| description = "주문 id", | ||
| example = "1" | ||
| ) | ||
| val orderId: Long, |
There was a problem hiding this comment.
SaveOrderResponse DTO 에서는 orderId를 orderNumber 와 같은 의미로 쓰고 있어서요. TossPayment 에 관한 DTO에서도 그렇구요. 오해의 소지가 있는 것 같습니다!
orderId 는 order 엔티티를 구분하는 식별자로 쓰고, 하나의 주문을 구분하는 식별자로 orderNumber 를 쓰면 어떨까요? SaveOrderResponse 를 변경하면 될 것 같습니다!
There was a problem hiding this comment.
통일해서 사용 하도록 할게요!
저도 작성하면서 헷갈리더라고요! 감사합니다
Comment on lines
+35
to
+36
| @Query("SELECT op FROM OrderPayment op WHERE op.orderId = :orderId ORDER BY op.id DESC LIMIT 1") | ||
| fun findOrderStatusByOrderId(orderId: Long): OrderPayment |
There was a problem hiding this comment.
최신 주문 상태만 깔끔하게 가져오는 게 멋지네요 👍
Comment on lines
85
to
92
| companion object { | ||
| fun from(memberId: Long, orderNumber: String): OrderDetailReadQuery { | ||
| return OrderDetailReadQuery( | ||
| memberId = memberId, | ||
| orderNumber = OrderNumber(orderNumber), | ||
| ) | ||
| } | ||
| } |
There was a problem hiding this comment.
변수가 하나일 때 from 을 쓰는 게 컨벤션으로 기억해요!
Comment on lines
+140
to
+150
| fun readDetail(query: OrderDetailReadQuery): OrderDetailResponse { | ||
| val orders = orderRepository.findByOrderNumberOrThrow(query.orderNumber) { OrderException(ORDER_NOT_FOUND) } | ||
| orders.forEach { it.validateOwner(query.memberId) } | ||
| val orderProductResponses = orderProductResponsesFromOrders(orders) | ||
| val representativeOrder = orders[0] | ||
| return OrderDetailResponse( | ||
| orderNumber = representativeOrder.orderNumber.value, | ||
| orderedAt = representativeOrder.createdAt, | ||
| orderProducts = orderProductResponses, | ||
| totalAmount = representativeOrder.totalAmount, | ||
| ) |
Combi153
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
📁 작업 설명
주문번호로 조회시, 상세 주문 내역 응답 API를 개발했습니다.
📸 작업화면
응답 예시
{ "orderNumber": "20240502000307AAAA7513EFAD", "orderedAt": "2024-05-02T00:03:07.685322", "orderProducts": [ { "orderId": 1, "orderStatus": "ORDER_CREATED", "productId": 1, "storeId": 1, "storeName": "storeA", "thumbnail": "image.jpg", "productName": "1", "quantity": 1, "sex": "FEMALE", "orderPrice": 1, "price": 1, "deliveryFee": 3000, "deliveryMethod": "COMMON" }, { "orderId": 2, "orderStatus": "ORDER_CREATED", "productId": 2, "storeId": 1, "storeName": "storeA", "thumbnail": "image.jpg", "productName": "2", "quantity": 1, "sex": "MALE", "orderPrice": 1, "price": 1, "deliveryFee": 3000, "deliveryMethod": "COMMON" } ], "totalAmount": 3002 }