refactor: command가 Nickname객체를 가지게 변경

petqua · May 16, 2024 · 70c3577 · 70c3577
1 parent 9cd87be
commit 70c3577
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 7 deletions.
diff --git a/src/main/kotlin/com/petqua/application/member/MemberService.kt b/src/main/kotlin/com/petqua/application/member/MemberService.kt
@@ -96,16 +96,16 @@ class MemberService(
         val member = memberRepository.findActiveByIdOrThrow(command.memberId) {
             MemberException(NOT_FOUND_MEMBER)
         }
-        member.updateNickname(Nickname.from(command.nickname))
+        member.updateNickname(command.nickname)
     }
 
-    private fun validateNickname(nickname: String, memberId: Long) {
-        validateContainingBannedWord(nickname)
+    private fun validateNickname(nickname: Nickname, memberId: Long) {
+        validateContainingBannedWord(nickname.value)
         validateDuplicatedNickname(nickname, memberId)
     }
 
-    private fun validateDuplicatedNickname(nickname: String, memberId: Long) {
-        throwExceptionWhen(memberRepository.existsMemberByNicknameAndIdNot(Nickname.from(nickname), memberId)) {
+    private fun validateDuplicatedNickname(nickname: Nickname, memberId: Long) {
+        throwExceptionWhen(memberRepository.existsMemberByNicknameAndIdNot(nickname, memberId)) {
             MemberException(ALREADY_EXIST_NICKNAME)
         }
     }

diff --git a/src/main/kotlin/com/petqua/application/member/dto/MemberDtos.kt b/src/main/kotlin/com/petqua/application/member/dto/MemberDtos.kt
@@ -5,6 +5,7 @@ import com.petqua.domain.member.PetFish
 import com.petqua.domain.member.PetFishCount
 import com.petqua.domain.member.PetFishSex
 import com.petqua.domain.member.PetFishes
+import com.petqua.domain.member.nickname.Nickname
 import java.time.YearMonth
 
 data class MemberSignUpCommand(
@@ -54,5 +55,8 @@ data class PetFishAddCommand(
 
 data class UpdateProfileCommand(
     val memberId: Long,
-    val nickname: String
-)
+    val nickname: Nickname,
+) {
+
+    constructor(memberId: Long, nickname: String) : this(memberId, Nickname.from(nickname))
+}