Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit Signing Does Not Work #3438

Closed
thetaiter-swf opened this issue Oct 10, 2024 · 1 comment
Closed

Commit Signing Does Not Work #3438

thetaiter-swf opened this issue Oct 10, 2024 · 1 comment

Comments

@thetaiter-swf
Copy link

Commit Signing Does Not Work

I have set sign-commits to true, but it does not happen. I checked the code, there is nothing set to ensure that commits are signed.

Steps to reproduce

Set up a gpg key and try setting sign-commits to true. It will not work.

@peter-evans
Copy link
Owner

Hi @thetaiter-swf

You're mixing up two different methods of commit signing. Please see the documentation here: https://github.com/peter-evans/create-pull-request/blob/main/docs/concepts-guidelines.md#commit-signing

If you want to use GPG for commit signing, leave sign-commits unset (false).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants