Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

customRoutes broken #42

Open
neonstalwart opened this issue Feb 9, 2015 · 0 comments
Open

customRoutes broken #42

neonstalwart opened this issue Feb 9, 2015 · 0 comments

Comments

@neonstalwart
Copy link
Member

jsgi/routes can take a customRoutes config array. i'm not sure what the elements of that array should look like but 2 obvious choices are:

  1. each element would be an array that becomes the arguments to declare
  2. each element is an object similar to the r variable used in declare.

however the way in which the elements are added won't work no matter what the elements are. also, if you provide null or undefined as the customRoutes then an error occurs because it's assumed to always be an array. i couldn't decide which way to fix this

  • should we just remove customRoutes?
  • should customRoutes be an array of r-like objects and then avoid calling declare and just push them onto routes?
  • should customRoutes be an array of arrays so that for each element we call declare.apply(null, customRoutes[ i ]);?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant