Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test targets in local packages not visible #770

Open
jfiser-paylocity opened this issue Jul 15, 2024 · 0 comments
Open

Test targets in local packages not visible #770

jfiser-paylocity opened this issue Jul 15, 2024 · 0 comments
Labels
needs investigation Bug report that needs confirmation
Milestone

Comments

@jfiser-paylocity
Copy link

After update to version 2.21.0, test targets in local swift packages are no longer visible to Periphery and therefore cannot be included in scan. This results in code being incorrectly reported as unused.

I think this is related to removal of the following code as part of c0846a6:

// Also include any test targets that depend upon this target, as they may be built by a scheme.
let testTargets = package.testTargets.filter { $0.depends(on: target) }
result[package, default: []].formUnion(testTargets)

Was removing support for test targets intentional? Is there any other way to include them in our scan? Or can this be fixed?

@ileitch ileitch added this to the v3 milestone Aug 4, 2024
@ileitch ileitch added the needs investigation Bug report that needs confirmation label Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs investigation Bug report that needs confirmation
Projects
None yet
Development

No branches or pull requests

2 participants