Skip to content

Commit 8cc2964

Browse files
committed
better combobox tests
1 parent 524b04a commit 8cc2964

20 files changed

Lines changed: 311 additions & 32 deletions

babel.config.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
{
2+
"env": { "development": { "compact": false } },
23
"presets": [
34
[ "@babel/preset-env", { "targets": { "node": "current" }} ]
45
]

docs/docs.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10589,6 +10589,7 @@ function instance13($$self2, $$props2, $$invalidate2) {
1058910589
originalText = inputElement2.value;
1059010590
if (showOnFocus)
1059110591
open({ type: "navigating" });
10592+
requestAnimationFrame(() => inputElement2.select());
1059210593
}
1059310594
function oninput() {
1059410595
open({ type: "typing" });
@@ -10598,9 +10599,8 @@ function instance13($$self2, $$props2, $$invalidate2) {
1059810599
$$invalidate2(19, newItemName = inputElement2.value);
1059910600
}
1060010601
function onblur() {
10601-
if (isSelecting)
10602-
return;
10603-
close();
10602+
if (!isSelecting)
10603+
close();
1060410604
}
1060510605
function onListMouseDown() {
1060610606
isSelecting = true;

docs/docs.js.map

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/ui.css

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/ui.css.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

jest.config.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
export default {
22
rootDir: './',
3+
// 10s - tests are interactive and have to wait for animations & rendering
4+
slowTestThreshold: 10,
35
transform: {
46
'^.+\\.svelte$': 'svelte-jester',
57
'^.+\\.js$': 'babel-jest',

src/input/combobox/Combobox.css

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,9 @@
3131
.combobox-list-header,
3232
.combobox-list-item {
3333
height: var(--ui-button-height);
34-
display: flex;
34+
line-height: var(--ui-button-height);
35+
display: block;
3536
align-items: center;
36-
line-height: 1;
3737
white-space: nowrap;
3838
text-overflow: ellipsis;
3939
overflow-x: hidden;

src/input/combobox/Combobox.svelte

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -391,6 +391,7 @@ function clear () {
391391
function onfocus () {
392392
originalText = inputElement.value;
393393
if (showOnFocus) open({ type: 'navigating' });
394+
requestAnimationFrame(() => inputElement.select());
394395
}
395396
396397
@@ -404,15 +405,7 @@ function oninput () {
404405
405406
406407
function onblur () {
407-
if (isSelecting) return;
408-
close();
409-
// if (!inputElement.value) {
410-
// if (multiselect || opened) return revert();
411-
// }
412-
// selectSingle();
413-
// setTimeout(() => {
414-
// if (document.activeElement != inputElement) close();
415-
// }, 200);
408+
if (!isSelecting) close();
416409
}
417410
418411

tests/Dialog.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { render, fireEvent } from '@testing-library/svelte';
2-
import userEvent from '@testing-library/user-event';
2+
import { default as userEvent } from '@testing-library/user-event';
33
import jest from 'jest-mock';
44

55
import { Dialog } from '../src/dialog';

tests/Drawer.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { render, fireEvent } from '@testing-library/svelte';
2-
import userEvent from '@testing-library/user-event';
2+
import { default as userEvent } from '@testing-library/user-event';
33
import jest from 'jest-mock';
44

55
import { Drawer } from '../src/drawer';

0 commit comments

Comments
 (0)