Skip to content
This repository was archived by the owner on Jun 21, 2022. It is now read-only.

Conversation

@igroene
Copy link
Member

@igroene igroene commented Jun 25, 2021

PMM-8544


  • Tests passed.
  • Feature build pass.
  • (Re)requested review.
  • Fix conflicts with target branch.
  • Update API dependency.
  • Update jira ticket description if needed.
  • Attach screenshots/console output to confirm new behavior to jira ticket, if applicable.

Screenshot 2021-08-17 at 12 41 23

@it-percona-cla
Copy link

it-percona-cla commented Jun 25, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@BupycHuk BupycHuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@igroene please add link to the task and update bindata by running

make env-up
make env TARGET=gen

@codecov
Copy link

codecov bot commented Aug 4, 2021

Codecov Report

Merging #790 (7cb13d1) into PMM-2.0 (828d1dc) will increase coverage by 0.02%.
The diff coverage is 83.33%.

❗ Current head 7cb13d1 differs from pull request most recent head cb50c20. Consider uploading reports for the commit cb50c20 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           PMM-2.0     #790      +/-   ##
===========================================
+ Coverage    49.35%   49.37%   +0.02%     
===========================================
  Files          168      168              
  Lines        18745    18757      +12     
===========================================
+ Hits          9252     9262      +10     
- Misses        8482     8483       +1     
- Partials      1011     1012       +1     
Flag Coverage Δ
all 48.97% <83.33%> (+0.02%) ⬆️
cover 48.84% <ø> (ø)
crosscover 49.37% <83.33%> (+0.02%) ⬆️
update 13.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
data/bindata.go 55.71% <83.33%> (+1.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 828d1dc...cb50c20. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants