Incorrect parameter quoting in restore script

[abh]

Report

The quoting of xbcloud arguments in run-restore.sh is incorrect. It makes the --curl-retriable-errors=7 --parallel=32 options (and --insecure if relevant) be sent to xbcloud as one option.

diff --git i/build/run-restore.sh w/build/run-restore.sh
index 94f12687..a200d527 100755
--- i/build/run-restore.sh
+++ w/build/run-restore.sh
@@ -11,15 +11,15 @@ if [ -n "$VERIFY_TLS" ] && [[ $VERIFY_TLS == "false" ]]; then
 fi
 
 run_s3() {
-	xbcloud get "${XBCLOUD_ARGS}" "${BACKUP_DEST}" --storage=s3 --s3-bucket="${S3_BUCKET}"
+	xbcloud get ${XBCLOUD_ARGS} "${BACKUP_DEST}" --storage=s3 --s3-bucket="${S3_BUCKET}"
 }
 
 run_gcs() {
-	xbcloud get "${XBCLOUD_ARGS}" "${BACKUP_DEST}" --storage=google --google-bucket="${GCS_BUCKET}"
+	xbcloud get ${XBCLOUD_ARGS} "${BACKUP_DEST}" --storage=google --google-bucket="${GCS_BUCKET}"
 }
 
 run_azure() {
-	xbcloud get "${XBCLOUD_ARGS}" "${BACKUP_DEST}" --storage=azure
+	xbcloud get ${XBCLOUD_ARGS} "${BACKUP_DEST}" --storage=azure
 }
 
 extract() {

More about the problem

I don't know what it does to not have the parallel option active, but having --insecure not work broke the restore in my environment.

Steps to reproduce

1. have an invalid certificate on the S3-type server
2. try a restore job
3. watch --insecure not do anything

Versions

1. Kubernetes
2. Operator
3. Database

Anything else?

No response