Repository navigation
SEP-1840: Expose pt-table-checksum --defaults-file as a Checksums form field - #1363
Merged
Merged
Conversation
github-actions
Bot
added
language:python
olucasandrade
marked this pull request as ready for review
August 18, 2026 20:44
olucasandrade
requested review from
a team,
marcuscruz-percona,
maxbube,
nachodd,
peter-o-addo and
yyyyyyyan
as code owners
August 18, 2026 20:44
olucasandrade
added
the
qa passed
yyyyyyyan
approved these changes
Aug 19, 2026
yyyyyyyan
approved these changes
Aug 19, 2026
Co-authored-by: olucasandrade <64823667+olucasandrade@users.noreply.github.com>
Contributor
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
defaults_filefield on the Checksums create form (Advanced section) so a task can pointpt-table-checksumat a dedicated MySQL options file instead of the executor's~/.my.cnf.--defaults-file(existing task args stay byte-identical). Non-empty values must be absolute POSIX paths; relative paths and~are rejected because they are not shell-expanded on the executor.Jira: SEP-1840
Tested
meta.args— no--defaults-file./etc/checksum.cnf. Inspectmeta.args— contains--defaults-file=/etc/checksum.cnf.rel.cnf) or~/.my.cnf— form validation 422 with an actionable absolute-path message./etc/checksum.cnf— Defaults File is restored.Checklist
make test) (checksums suite + schema/OpenAPI goldens;make lintclean)make run-pre-commit) (ran on commit)Database migrations generated if models changed ((N/A — value lives in taskmake makemigrations)data['_form']/ args only)Ui(description=...))Configuration changes documented with examples(N/A)changelog.d/if the change is user-facing (make changelog-add), or confirmed N/A (internal-only change, or a same-release-cycle fix for an unreleased sibling ticket)