Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Smell: poor code organization #5125

Open
TestSmell opened this issue Aug 29, 2022 · 1 comment
Open

Test Smell: poor code organization #5125

TestSmell opened this issue Aug 29, 2022 · 1 comment

Comments

@TestSmell
Copy link

Hi!

We notice that your way of naming test files doesn't follow the common naming convention.
For example, a test file is named ''https://github.com/pentaho/pentaho-platform/blob/master/repository/src/it/java/com/pentaho/pdi/ws/RepositorySyncWebServiceIT.java''

The common convention (good practice) is to add the term ''Test'' or ''test'' in the path or file name for the test cod.
Since it makes other readers easier to understand what source files are production code or test code.

Your way of naming test files is difficult for others to understand which are test files and it feels like mixing test code with production code.
It is a bad code organization. Thanks.

@henjovr
Copy link

henjovr commented Jun 20, 2023

Disagree on that particular example:

That test class is an integration test, which follows the conventions for naming: *IT.java
https://maven.apache.org/surefire/maven-failsafe-plugin/examples/inclusion-exclusion.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants