-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for (ticket) email blasts #749
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the lead on this: you might have to add the action name to the relevant code in EventPermission
in order to ensure that only club leaders use it but looks good otherwise. Also, would it be possible to take a first crack at the UI? Shouldn't be more than 20 or so loc in the club-specific ticket page.
Sure, but I think the plan is to have a designer take a crack at the UI before we make any changes or additions to it. We're going to need to change how the ticket dashboard looks to club leaders a lot (add refunds, email blasts, revenue metrics, question answers, etc.). Let me know if that sounds reasonable. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #749 +/- ##
==========================================
+ Coverage 71.95% 71.99% +0.04%
==========================================
Files 32 32
Lines 6953 6964 +11
==========================================
+ Hits 5003 5014 +11
Misses 1950 1950 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than one nit.
Adds support for email blasts from event owners to ticket holders. I'm envisioning using this for an admin feature as well (ex: OSA wants to send a message to all club leaders, like they did at the start of this semester).
Here's what an event-related email might look like: