add empty template check when no external url is set

pennlabs · Sep 24, 2023 · 8f3d74e · 8f3d74e
1 parent 665950c
commit 8f3d74e
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/backend/clubs/serializers.py b/backend/clubs/serializers.py
@@ -2644,6 +2644,12 @@ def get_image_url(self, obj):
     def validate(self, data):
         acceptance_template = data.get("acceptance_email", "")
         rejection_template = data.get("rejection_email", "")
+        external_url = self.context["request"].data.get("external_url")
+
+        if not external_url and not (acceptance_template and rejection_template):
+            raise serializers.ValidationError(
+                "Your application email templates cannot be empty!"
+            )
 
         if not ClubApplication.validate_template(
             acceptance_template