Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement --version command #456

Open
TorstenStueber opened this issue Apr 22, 2024 · 7 comments · May be fixed by #485
Open

Implement --version command #456

TorstenStueber opened this issue Apr 22, 2024 · 7 comments · May be fixed by #485
Assignees

Comments

@TorstenStueber
Copy link
Member

Ensure that the node clients return the version number, see this message from a third party collator:

is it possible to have versioning on collators binaries? so when we use ./amplitude-collator --version we get the correct node version and also it will be displayed on telemetry correctly, so you can check for every provider which version is running

@TorstenStueber
Copy link
Member Author

Hey team! Please add your planning poker estimate with Zenhub @b-yap @bogdanS98 @ebma @gianfra-t

@ebma
Copy link
Member

ebma commented Apr 23, 2024

This ticket also entails updating our version numbers in all Cargo.toml files, doesn't it? Is this something we should talk about @TorstenStueber? Like, when do we want to bump to new major, minor, or patch versions? Or do we want to keep this number aligned to something else?

@TorstenStueber
Copy link
Member Author

Mmhh, I did not think about this. Just thought that the version number could just be the version of the runtime. But that would not really be correct...

Then it probably makes sense to track the version of the client in the Cargo.toml of the client. We would then need to define a scheme for version numbers.

@gianfra-t
Copy link
Contributor

I think the current node-template already has this --version flag. Not sure what it returns, but it is likely that the person was referring to this. If this is the case we should modify the client to return the same to be consistent with later versions.

@TorstenStueber
Copy link
Member Author

Yes, that would make sense.

@ebma
Copy link
Member

ebma commented Apr 25, 2024

As far as I know, our node binaries also already support the --version flag but it's currently quite useless as we don't update the version in the Cargo.toml files which is probably the main concern of the external operators.

@TorstenStueber
Copy link
Member Author

Okay, so the right solution would just be to add the workflow that for every client release we actively bump the version and nothing else would need to be done here ....

@b-yap b-yap self-assigned this Jun 17, 2024
@b-yap b-yap linked a pull request Jul 4, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants