Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Github workflow to run tests with feature flags #420

Open
bogdanS98 opened this issue Feb 21, 2024 · 2 comments
Open

Change Github workflow to run tests with feature flags #420

bogdanS98 opened this issue Feb 21, 2024 · 2 comments
Assignees

Comments

@bogdanS98
Copy link
Contributor

Context

At the moment, our Github workflow is running cargo test without any feature flags. This allows for changes that break benchmarks to pass the pipeline and therefore be merged into the main branch. This will cause building the main branch with runtime-benchmarks feature to fail. The same thing happens for pallets/runtimes (i.e. development runtime) that do not properly declare the try-runtime feature.

Requirement

Pipeline should be changed so that it runs cargo test --features runtime-benchmarks try-runtime

Notes

Before changing the workflow to run tests with the try-runtime feature, development runtime must be removed since it's not used anymore and it's causing errors when built with try-runtime. There's already an open ticket for deleting this runtime here.

@bogdanS98
Copy link
Contributor Author

@pendulum-chain/product This is not urgent but would be nice to have it fixed.

@prayagd
Copy link
Collaborator

prayagd commented Feb 22, 2024

@b-yap b-yap self-assigned this Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants