Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve XCM integration tests #293

Open
ebma opened this issue Aug 7, 2023 · 4 comments
Open

Improve XCM integration tests #293

ebma opened this issue Aug 7, 2023 · 4 comments
Labels
priority:low Do it some day type:chore Maintenance tasks

Comments

@ebma
Copy link
Member

ebma commented Aug 7, 2023

This is a follow-up task to PR #290.

We identified that the integration tests for testing relay-chain transfers via XCM can be improved. We originally adopted these integration tests from Acala, but they added some improvements in the meantime, for example, more flexible fee calculations for asset-hub transfers, see this file, that would make us a little less dependent on hard-coded values.

TODO

We should have another look at Acala's integration tests for relay-chain transfers and try to adopt the latest best-practices.

@ebma ebma added priority:low Do it some day type:chore Maintenance tasks labels Aug 7, 2023
@ebma
Copy link
Member Author

ebma commented Aug 7, 2023

@pendulum-chain/product I created this very technical ticket. It's more about refactoring and we don't get any new features out of this. It's also not fixing a bug, so not critical. Just nice to have eventually.

@vadaynujra
Copy link

@ebma based on your comment I assume this is not required to be completed before this ticket. From an epic pov, would this be more about improving our QA process in general or having a better XCM overview / knowledge?

@ebma
Copy link
Member Author

ebma commented Aug 8, 2023

I'd say this is more about improving the QA process. We could catch some more issues with improving the integration tests. While doing so we might also gain a little extra XCM knowledge but that's more a minor side effect I'd say.

@prayagd
Copy link
Collaborator

prayagd commented Dec 7, 2023

@ebma Moving this to icebox based on your comment as this nice to have

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:low Do it some day type:chore Maintenance tasks
Projects
None yet
Development

No branches or pull requests

3 participants