Skip to content

Commit b680842

Browse files
authored
fix(street_suffix): remove "ga" as a street suffix (#122)
* remove "ga" as a street suffix this suffix is breaking us queries like "jasper ga" Wikipedia says "Streets diverging from -gil are named after -gil with the diverging -gil with the additional number in Korean alphabet: ga (가), na (나), da (다), ra (라), ma (마) ... For example, the third diverging street of Daehak-ro 4-gil (대학로4길) would be Daehak-ro 4da-gil (대학로4다길). This secondary diverging numbering is applied to all of the numbering rules. " But we can't parse the string "Daehak-ro 4da-gil" (or ".. 4ga-gil") so it seems like for now it's better to blacklist this common abbreviation * add test for jasper ga
1 parent daf965c commit b680842

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
!ga

test/functional.test.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,9 @@ const testcase = (test, common) => {
8888
assert('new south wales aus', [
8989
{ region: 'new south wales' }, { country: 'aus' }
9090
])
91+
92+
// test that we don't interpret "ga" as a street suffix
93+
assert('jasper ga', [{ locality: 'jasper' }, { region: 'ga' }])
9194
}
9295

9396
module.exports.all = (tape, common) => {

0 commit comments

Comments
 (0)