From 697145d51efa6ca91533e862a92e9ee368e79a7e Mon Sep 17 00:00:00 2001 From: David Blackman Date: Sun, 2 Aug 2020 17:37:51 -0400 Subject: [PATCH] feat: remove "art" as a steet suffix/type and locality (#116) --- resources/pelias/dictionaries/libpostal/en/street_names.txt | 2 ++ resources/pelias/dictionaries/libpostal/en/street_types.txt | 5 ++++- .../whosonfirst/locality/name:eng_x_preferred.txt | 2 ++ test/venue.usa.test.js | 5 +++++ 4 files changed, 13 insertions(+), 1 deletion(-) create mode 100644 resources/pelias/dictionaries/libpostal/en/street_names.txt diff --git a/resources/pelias/dictionaries/libpostal/en/street_names.txt b/resources/pelias/dictionaries/libpostal/en/street_names.txt new file mode 100644 index 00000000..dc1b8316 --- /dev/null +++ b/resources/pelias/dictionaries/libpostal/en/street_names.txt @@ -0,0 +1,2 @@ +# bad abbreviation for the very uncommon suffix "Artery" +!art diff --git a/resources/pelias/dictionaries/libpostal/en/street_types.txt b/resources/pelias/dictionaries/libpostal/en/street_types.txt index 09197194..1bdfe95a 100644 --- a/resources/pelias/dictionaries/libpostal/en/street_types.txt +++ b/resources/pelias/dictionaries/libpostal/en/street_types.txt @@ -2,4 +2,7 @@ paku # Rushendon Furlong, Pitstone, England -furlong \ No newline at end of file +furlong + +# bad abbreviation for the very uncommon suffix "Artery" +!art diff --git a/resources/pelias/dictionaries/whosonfirst/locality/name:eng_x_preferred.txt b/resources/pelias/dictionaries/whosonfirst/locality/name:eng_x_preferred.txt index 0525e9a8..ccee1b56 100644 --- a/resources/pelias/dictionaries/whosonfirst/locality/name:eng_x_preferred.txt +++ b/resources/pelias/dictionaries/whosonfirst/locality/name:eng_x_preferred.txt @@ -15,6 +15,8 @@ sf !germany !empire !unit +# 18 person county in texas +!art # remove any localities which share a name with a US state !alabama !alaska diff --git a/test/venue.usa.test.js b/test/venue.usa.test.js index 3d4b2d30..4a5566e1 100644 --- a/test/venue.usa.test.js +++ b/test/venue.usa.test.js @@ -10,6 +10,11 @@ const testcase = (test, common) => { { venue: 'Empire State Building' }, { locality: 'NYC' } ]) + + // checking that "art" is not interpreted as a street suffix + assert('philadelphia museum of art', [ + { venue: 'philadelphia museum of art' } + ]) } module.exports.all = (tape, common) => {