Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISSUE-711: add support for securityContext to SRS #712

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

ISSUE-711: add support for securityContext to SRS #712

wants to merge 7 commits into from
+16 −0

Conversation

konire
Copy link

@konire konire commented Feb 23, 2024

Fixes #711

@konire konire requested a review from a team as a code owner February 23, 2024 10:08
@kishorv10
Copy link
Contributor

@konire Can you fix the lint issues?

@kishorv10 kishorv10 requested a review from a team April 25, 2024 10:18
@dekke046
Copy link

@kishorv10 @konire ,

Can you please have a look how to incoporate this on a global level for each chart?
So not only for the backingservices, but also for pega and addons?

That gives the possibily to have it all in a universal way for the values.yaml files for each chart.

Secondly it is important to also properly propagate it to the helpers, like wait-for-pegasearch and part of base images like pega-web-tomcat, search

Thanks!

@kishorv10 kishorv10 mentioned this pull request May 14, 2024
Merged
@kishorv10
Copy link
Contributor

@reddy-srinivas @ravitejamekapega Can you review the PR?

MadhuriArugula
MadhuriArugula requested changes Jun 21, 2024
View reviewed changes
charts/backingservices/charts/srs/templates/srsservice_deployment.yaml
@@ -105,6 +105,10 @@ spec:
value: ""
resources:
{{- toYaml .Values.srsRuntime.resources | nindent 12 }}
securityContext:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need the securityContext key if Values.srsRuntime.securityContext is not provided in values.yaml?
Can you please add unit tests for the same?

@kishorv10
Copy link
Contributor

kishorv10 commented Sep 30, 2024 •
edited
Loading

#806 provides the required capabilities looking from this PR. Probably this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MadhuriArugula MadhuriArugula MadhuriArugula requested changes

@kishorv10 kishorv10 kishorv10 approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SRS add support for setting securityContext
4 participants
@konire @kishorv10 @dekke046 @MadhuriArugula