Redis::Client#call_pipelined

[pietern]

Pipelined calls are not instrumented. I just glanced over the code to see how you instrumented Redis and found this. I'm not familiar enough with the project to whip up a quick pull request, my apologies.

[dewski]

This was something I wanted to address, thanks for making an issue. I see you had some commits on the pipeline code over at redis/redis-rb. Since you have some familiarity already, where would the best place to hook into each command that gets executed through the pipeline? As you can see the code just uses alias_method_chain to catch the call method. I'll take a look myself as well.

[dewski]

As you mentioned, there is Redis::Client#call_pipelined but that doesn't look like it captures each individual command. It ends up calling connection.write(command) in Redis::Client#io. Maybe that's where it has to be tracked.

[pietern]

The best place would be #call_pipelined. It takes an array of commands that can drive the command counter. Timing of pipelines is radically different from timing individual commands because of the included round trips, so it might give skewed information (many commands / short time vs few commands / long time). Maybe this is something to split out as a different status.

[dewski]

Good to know, thanks for the info on that. I'll cc you in the PR so you can check it out. 👍