-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redis::Client#call_pipelined #1
Comments
This was something I wanted to address, thanks for making an issue. I see you had some commits on the pipeline code over at redis/redis-rb. Since you have some familiarity already, where would the best place to hook into each command that gets executed through the pipeline? As you can see the code just uses alias_method_chain to catch the call method. I'll take a look myself as well. |
As you mentioned, there is |
The best place would be |
Good to know, thanks for the info on that. I'll cc you in the PR so you can check it out. 👍 |
Pipelined calls are not instrumented. I just glanced over the code to see how you instrumented Redis and found this. I'm not familiar enough with the project to whip up a quick pull request, my apologies.
The text was updated successfully, but these errors were encountered: