Resource metadata for URIs when mount() is used. Some preg_match issue fixes

[ivolator]

Hello,
Here are couple of bugs i needed to fix in the instance I am running. Those bugs seem to be present in the latest code too.

When setting the Lines 109 and 240 there is a mismatch with the 'uri parameter.
Line 109 should be $this->resources[$className]['uri'][] = ....
Line 240 should be $metadata['uri'][] = ....

On that note I notice that there is a call to loadResourceMetadata() in the __construct() and the baseUri is not being passed.

On line 43: doing this $this->loadResourceMetadata($this->baseUri); instead of $this->loadResourceMetadata(); correctly allows you to set relative URIs in the resources.

On an improvement note (also fixing another bug):
The addition of '|^' and '$|' causes preg_match to issue a warning for URIs where '|^' is missing.
Suggested fix here is to not append the former delimiter strings at lines 90 and 109, but instead do it on line 181 preg_match('|^' . $uriRegex . '$|' , $request->uri, $params).
This would make it easier to read and avoid doing the substr() ...

Thanks!

[peej]

Hi ivolator,

Thanks for reporting these issues.

Not knowing what is causing the problem, it's not possible for me to test what effects the uri parameter amends have. Do you think you could update the mounting.feature Behat feature to test these cases?

The adjustment of the uri regexp is a great improvement, thanks.

[ivolator]

Sure. I'll find the time during the weekend to setup environment.
Regards!

[peej]

Hi @ivolator, did you get anywhere with this? If not, can you provide an example of the code that causes the issue?