Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Tooltip to BottomNavyBar.items #50

Open
sterrenb opened this issue Mar 6, 2020 · 1 comment · May be fixed by #91
Open

Adding Tooltip to BottomNavyBar.items #50

sterrenb opened this issue Mar 6, 2020 · 1 comment · May be fixed by #91
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone
January 21

Comments

@sterrenb
Copy link

sterrenb commented Mar 6, 2020

Hello, I would like to add a Tooltip to every item in BottomNavyBar.items.

Currently, the items cannot easily be wrapped in a Tooltip since BottomNavyBar.items has the explicit type List<BottomNavyBarItem>.

Ideally, I think BottomNavyBar.items should be of type List<Widget> instead. Then, the BottomNavyBarItems can be wrapped with other Widgets without impacting the interface.

This works well in existing native Widgets, for example IconButton. IconButton.icon is typically an Icon, but the interface specifies Widget.

What are your thoughts on using the generic Widget type in this case?
@pedromassango pedromassango added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Mar 6, 2020
@pedromassango pedromassango added this to the January 21 milestone Nov 25, 2020
@pedromassango
Copy link
Owner

I will probably work on this in January when I will have more free time.

@shahabhm shahabhm linked a pull request Jul 15, 2021 that will close this issue
Open
@antonio-pedro99 antonio-pedro99 linked a pull request Sep 16, 2023 that will close this issue
Added Tooltip to BottomNavyBar.items #91
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
January 21
Development

Successfully merging a pull request may close this issue.

Added Tooltip to BottomNavyBar.items shahabhm/bottom_navy_bar
2 participants
@sterrenb @pedromassango