From d7709f0e5699aecbc6ab32012daab9fed867a2fe Mon Sep 17 00:00:00 2001 From: Willow Systems Date: Mon, 25 Oct 2021 21:07:27 +0100 Subject: [PATCH] fix 500 when a new developer who hasn't setup their account tries to rename themselves --- appstore/dev_portal_api.py | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/appstore/dev_portal_api.py b/appstore/dev_portal_api.py index a04a4f7..409c8ac 100644 --- a/appstore/dev_portal_api.py +++ b/appstore/dev_portal_api.py @@ -106,12 +106,14 @@ def update_my_developer(): me = result.json() developer_id = me["id"] - developer = Developer.query.filter_by(id=developer_id).one() - print("Update developer from " + developer.name + " to " + req["name"]) - developer.name = req["name"] - db.session.commit() - - return jsonify(success=True, id=developer.id, name=developer.name) + developer = Developer.query.filter_by(id=developer_id).one_or_none() + if developer is not None: + print("Update developer from " + developer.name + " to " + req["name"]) + developer.name = req["name"] + db.session.commit() + return jsonify(success=True, id=developer.id, name=developer.name) + else + return jsonify(success=False, error="You do not have a developer ID to rename. Set up your account first.", e="account.nonexistant"), 400 @legacy_api.route('/applications//add_heart', methods=['POST'])