Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset of contest does not reset thawed time #1050

Open
johnbrvc opened this issue Mar 9, 2025 · 0 comments
Open

Reset of contest does not reset thawed time #1050

johnbrvc opened this issue Mar 9, 2025 · 0 comments
Labels
bug Something isn't working NEXT Contest Consider fixing for next contet One Approval A very low risk and low LOE PR/Change Primary CCS Required for PC2 to act as primary CCS Small LOE Less than an hour to code, test and push a PR Usability Issue This is an enhancement for which there is currently no usable workaround

Comments

@johnbrvc
Copy link
Collaborator

johnbrvc commented Mar 9, 2025

Describe the issue:
After resetting a contest from the Profiles tab, the contest thaw time is not cleared.

To Reproduce:

  1. Reset a contest where the contest has been frozen and then unfrozen (thawed).
  2. State events on an event will will show that the "thawed" property is still set to the previous contest thaw time.

Expected behavior:
The thaw time should be cleared if the contest is reset.

Actual behavior:
The ContestInformation thaw time is simply copied from the original contest (before reset) to the new contest (reset contest), thereby preserving the thawed member.

Environment:
All.

Log Info:

Screenshots:

Additional context:
Event feed message after a contest profile reset:
{"type":"state","token":"pc2-11","id": null,"data": {"started":"2025-03-09T14:00:00.042-04","frozen":null,"ended":null,"thawed":"2025-03-09T13:46:01.079-04","finalized":null,"end_of_updates":null,"paused":null,"resumed":"2025-03-09T14:00:00.042-04","contest_time":"00:00:04.044"}}

This happens in InternalContest.java, around line 3000:

        ContestInformation newContestInformation;
        if (settings.isCopyContestSettings()) {
            newContestInformation =  getContestInformation();
        } else {
            newContestInformation = new ContestInformation();
        }

The thawed member should be set to null if theisCopyContestSettings()is true.

@johnbrvc johnbrvc added bug Something isn't working Usability Issue This is an enhancement for which there is currently no usable workaround Small LOE Less than an hour to code, test and push a PR NEXT Contest Consider fixing for next contet One Approval A very low risk and low LOE PR/Change Primary CCS Required for PC2 to act as primary CCS labels Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working NEXT Contest Consider fixing for next contet One Approval A very low risk and low LOE PR/Change Primary CCS Required for PC2 to act as primary CCS Small LOE Less than an hour to code, test and push a PR Usability Issue This is an enhancement for which there is currently no usable workaround
Projects
None yet
Development

No branches or pull requests

1 participant