Allow WTI viewing of Clars (always) and Problems (any time after contest has been started)

[clevengr]

Describe the issue:

Currently the WTI code (specifically, the ContestController class in the WTI-API controllers package) supports HTTP endpoints /clarifications (which returns a list of current clarifications) and /problems (which returns a list of the current contest problems). Both these endpoints have code at the beginning which requires two conditions to be met: the requesting user must be logged in, and the contest must be "running" (i.e., has been started and is not currently stopped (a.k.a. "paused"). If either of these conditions is false, the endpoint returns "401 - Not Authorized".

There doesn't seem to be any logical reason for requiring that the contest be "running" in order for a user to see a list of clarifications -- for example, a contest admin might want to send a "clarification" (announcement) like "The start of the contest has been delayed; it will start at 9:20". The requirement of the /clarifications endpoint that the contest be "running" means that logged in users won't be able to see this if it is sent before the contest starts.

Similarly, there doesn't seem to be any reason to prohibit viewing of the contest problems after the contest has been started (for example, during a "pause"); once the contest has been started then teams have already seen (or at least, had the opportunity to see) the contest problems -- but the current /problems endpoint implementation won't allow them to continue to see them if the contest is paused.

To Reproduce:

• Start a PC2 Server loading a contest containing at least one problem; make sure the contest.yaml config does NOT indicate that the contest should be "running" (i.e., make sure that the contest has never been started).
• Start a WTI server.
• Start a PC2 Admin; send a clarification announcement "To All Teams".
• Open a browser and login to the WTI.
• Select the "Clarifications" menu item in the browser.
• On the Admin, "start" the contest, wait a moment, then "stop" (pause) the contest.
• On the team, select the "Runs" tab and then click the "Problems" dropdown.

Expected behavior:

• The logged in team should be able to see the clarification announcement before the contest has started.
• The logged in team should be able to see the problem list once the contest has been started and then paused.

Actual behavior:

The browser console will show multiple Errors ("401 - Not Authorized") from the "Clarifications" request; the team will not be able to see the problem list when the contest is paused (after it has been started).

Environment:

All.

Additional context:

Two suggested steps to fix this issue:

• Remove the else condition in the /clarifications endpoint (just after the check for userInformation == null) that checks if (... isContestClockRunning()). This will allow logged in users to see clarifications regardless of whether the contest is running or not.
• Replace the analogous test in the /problems endpoint (the test for if (... isContestClockRunning()) ) with a test that checks if (contestHasBeenStarted()). This will allow logged in users to see contest problems any time after the contest has been started.

Note: there (probably) is not an existing method contestHasBeenStarted(). A simple equivalent test might be to test if the contest elapsed time is greater than zero.

[clevengr]

Since the error message which exposed this issue came to light as part of testing for #1027, the fix for it will be included in the PR for that issue.