Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace old convergence checks with sanity() #18

Open
seananderson opened this issue Feb 22, 2023 · 1 comment
Open

Replace old convergence checks with sanity() #18

seananderson opened this issue Feb 22, 2023 · 1 comment
Assignees

Comments

@seananderson
Copy link
Member

Replace

  both_converged <- all(
    (max(m1$gradients) < 0.005), (max(m2$gradients) < 0.005),
    !m1$bad_eig, !m2$bad_eig,
    m1$sd_report$pdHess, m2$sd_report$pdHess

Replace

(max(m$gradients) < 0.1 && !m$bad_eig && m$sd_report$pdHess

with

x <- sanity(model_name)
all(unlist(x))

note that sanity() returns FALSE with NULL or "try-error" to help out

@seananderson
Copy link
Member Author

This is lower priority if we just want to leave it as is for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants