R CMD check errors

[seananderson]

There have been lots of errors on R CMD check on continuous integration since about 3 weeks ago. I'm getting errors locally too, but there are so many issues I'm not sure where to start or what precipitated this. @cgrandin do you know what's going on? @ricardd

[cgrandin]

It's my fault, I will fix them.

I was fixing some of the problems with copying (or not) the sty file on compile and setting up line numbering, draft watermark, etc. it turns out its complicated to do that if the person has decided not to copy the sty file, because that file could now have anything in it and not be in a known state. The way it was was a bit of a mess and there was a couple of bugs I stumbled across while trying to compile a document. I really should have used a branch, my bad on this one.

[ricardd]

@cgrandin glad that it is traceable and can be fixed, I have a ResDoc to finish and was kind of stumped at not being able to render.

I will keeping an eye out on the commits and will rebuild once you have fixed the issue.

[seananderson]

So that we have a working main branch, I have reverted the files in R and inst/csas-style/res-doc.sty to how they were before the package broke, i.e. to their state as of commit b4e6c61601e4.

That is done by these 2 commits:
c49c896
67e85fb

I attempted to not touch any the modifications to docx parts that you worked on @ricardd, but may have missed something. All unit tests pass again on my machine and all document types are rendering.

[ricardd]

Why would the tests pass on GitHub but not on my local machine?

I get an error from the test-update-csasstyle about pandoc not being found (screenshot below). That's using RStudio's Build->Test, which invokes devtools::test(). But all tests pass when I submit a pull request.

[seananderson]

Likely because I missed removing one of the pandoc package calls that was added in the unit tests and the pandoc R package is in Suggests but not Imports so you may not have had it installed locally. Should be fixed now. da831f1