Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Darwin uses dylib not so #156

Open
pbiggar opened this issue Jun 3, 2015 · 9 comments
Open

Darwin uses dylib not so #156

pbiggar opened this issue Jun 3, 2015 · 9 comments

Comments

@pbiggar
Copy link
Owner

pbiggar commented Jun 3, 2015

What steps will reproduce the problem?
1. none required
2.
3.

What is the expected output? What do you see instead?
this seems to only affect boost during configure so far

What version of the product are you using? On what operating system?
0.3.0.1, OSX 10.7.4 (Darwin 11.4.0)

Please provide any additional information below.
this is my current patch to fix this for darwin.


Index: m4/ax_boost_regex.m4
===================================================================
--- a/m4/ax_boost_regex.m4      (revision 3418)
+++ b/m4/ax_boost_regex.m4      (working copy)
@@ -72,7 +72,7 @@
                        AC_DEFINE(HAVE_BOOST_REGEX,,[define if the Boost::Regex library
is available])
             BOOSTLIBDIR=`echo $BOOST_LDFLAGS | sed -e 's/@<:@^\/@:>@*//'`
             if test "x$ax_boost_user_regex_lib" = "x"; then
-                for libextension in `ls $BOOSTLIBDIR/libboost_regex*.{so,a}* 2>/dev/null
| sed 's,.*/,,' | sed -e 's;^lib\(boost_regex.*\)\.so.*$;\1;' -e 's;^lib\(boost_regex.*\)\.a*$;\1;'`
; do
+                for libextension in `ls $BOOSTLIBDIR/libboost_regex*.{dylib,so,a}*
2>/dev/null | sed 's,.*/,,' | sed -e 's;^lib\(boost_regex.*\)\.dylib$;\1;' -e 's;^lib\(boost_regex.*\)\.so.*$;\1;'
-e 's;^lib\(boost_regex.*\)\.a*$;\1;'` ; do
                      ax_lib=${libextension}
                                    AC_CHECK_LIB($ax_lib, exit,
                                  [BOOST_REGEX_LIB="-l$ax_lib"; AC_SUBST(BOOST_REGEX_LIB)
link_regex="yes"; break],

Original issue reported on code.google.com by thesin on 2012-06-19 15:04:49

@pbiggar
Copy link
Owner Author

pbiggar commented Jun 3, 2015

Can you submit this as a pull request to https://github.com/pbiggar/phc?

Original issue reported on code.google.com by paul.biggar on 2012-06-19 16:49:02

@pbiggar
Copy link
Owner Author

pbiggar commented Jun 3, 2015

m4/ax_boost_regex.m4 doesn't seem to exist in https://github.com/pbiggar/phc?

Original issue reported on code.google.com by thesin on 2012-06-19 17:10:54

@pbiggar
Copy link
Owner Author

pbiggar commented Jun 3, 2015

Oh, that's an upstream package, I think autoconf-archive. We probably havent updated
that in years, maybe this change has been incorporated already?

Original issue reported on code.google.com by paul.biggar on 2012-06-19 17:31:11

@pbiggar
Copy link
Owner Author

pbiggar commented Jun 3, 2015

it's possible I'll see if I can find it upstream and see what it's state is

Original issue reported on code.google.com by thesin on 2012-06-19 17:32:19

@pbiggar
Copy link
Owner Author

pbiggar commented Jun 3, 2015

yes according to http://git.savannah.gnu.org/gitweb/?p=autoconf-archive.git;a=blob;f=m4/ax_boost_regex.m4;hb=HEAD

this is already done upstream and should be updated at next release.

Original issue reported on code.google.com by thesin on 2012-06-19 17:38:38

@pbiggar
Copy link
Owner Author

pbiggar commented Jun 3, 2015

I think I once tried to include the packages we use from autoconf-archive into the m4
directory. Are there some packages in there? If so, we should upgrade these packages
in the phc repository.

Original issue reported on code.google.com by paul.biggar on 2012-06-19 17:44:55

@pbiggar
Copy link
Owner Author

pbiggar commented Jun 3, 2015

it looks like phc uses ax_boost_base.m4, ax_boost_regex.m4, ax_lib_xerces.m4 so those
may all need to get updates though only ax_boost_regex.m4 is giving me configure problems
on darwin currently.

Original issue reported on code.google.com by thesin on 2012-06-19 17:58:45

@pbiggar
Copy link
Owner Author

pbiggar commented Jun 3, 2015

that seems right. You should just copy them into the m4 directory in the repo :)

Original issue reported on code.google.com by paul.biggar on 2012-06-19 18:40:08

@pbiggar
Copy link
Owner Author

pbiggar commented Jun 3, 2015

I'll add them in and give you a pull request

Original issue reported on code.google.com by thesin on 2012-06-19 19:38:13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant