Skip to content

Commit 7c9a7f6

Browse files
califlowerdaveshanley
authored andcommitted
Clean up test comments for consistency with codebase style
1 parent 28bfb46 commit 7c9a7f6

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

datamodel/high/base/schema_proxy_test.go

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -521,7 +521,6 @@ func TestSchemaProxy_ConcurrentCacheAccess(t *testing.T) {
521521
}
522522

523523
func TestSchemaProxy_ParentProxyPreservedForCachedSchemas(t *testing.T) {
524-
// Create schema that will be cached
525524
const ymlComponents = `components:
526525
schemas:
527526
TestSchema:
@@ -535,7 +534,6 @@ func TestSchemaProxy_ParentProxyPreservedForCachedSchemas(t *testing.T) {
535534
assert.NoError(t, err)
536535
idx := index.NewSpecIndexWithConfig(&idxNode, index.CreateOpenAPIIndexConfig())
537536

538-
// Create first proxy and get schema (this will cache it)
539537
const ymlSchema = `$ref: '#/components/schemas/TestSchema'`
540538
var node1 yaml.Node
541539
yaml.Unmarshal([]byte(ymlSchema), &node1)
@@ -547,12 +545,10 @@ func TestSchemaProxy_ParentProxyPreservedForCachedSchemas(t *testing.T) {
547545
Value: lowProxy1, ValueNode: node1.Content[0],
548546
})
549547

550-
// Get schema from first proxy (this should cache it)
551548
schema1 := proxy1.Schema()
552549
assert.NotNil(t, schema1)
553550
assert.Equal(t, proxy1, schema1.ParentProxy, "First schema should have correct ParentProxy")
554551

555-
// Create second proxy for same schema reference
556552
var node2 yaml.Node
557553
yaml.Unmarshal([]byte(ymlSchema), &node2)
558554

@@ -563,12 +559,8 @@ func TestSchemaProxy_ParentProxyPreservedForCachedSchemas(t *testing.T) {
563559
Value: lowProxy2, ValueNode: node2.Content[0],
564560
})
565561

566-
// Get schema from second proxy (this should return cached schema)
567562
schema2 := proxy2.Schema()
568563
assert.NotNil(t, schema2)
569-
570-
// CRITICAL TEST: Each proxy should have its own parent relationship
571-
// Currently fails due to the race condition fix
572564
assert.Equal(t, proxy2, schema2.ParentProxy, "Second schema should have its own ParentProxy, not the first proxy's")
573565
assert.NotEqual(t, schema1.ParentProxy, schema2.ParentProxy, "Different proxies should have different parent relationships")
574566
}

0 commit comments

Comments
 (0)