Latest YAML v4 handles tags differently.

setting bools, ints and floats causes rendering to fail tests. it’s automatically inferred.

Author: daveshanley

datamodel/high/node_builder.go

@@ -5,7 +5,6 @@ package high
 
 import (
 	"fmt"
-	"math"
 	"reflect"
 	"sort"
 	"strconv"
@@ -328,12 +327,11 @@ func (n *NodeBuilder) AddYAMLNode(parent *yaml.Node, entry *nodes.NodeEntry) *ya
 		precision := -1
 		if entry.StringValue != "" && strings.Contains(entry.StringValue, ".") {
 			precision = len(strings.Split(fmt.Sprint(entry.StringValue), ".")[1])
-			val := strconv.FormatFloat(value.(float64), 'f', precision, 64)
-			valueNode = utils.CreateFloatNode(val)
-		} else {
-			val := strconv.FormatFloat(value.(float64), 'f', precision, 64)
-			valueNode = utils.CreateIntNode(val)
 		}
+		val := strconv.FormatFloat(value.(float64), 'f', precision, 64)
+		// Always create float node for float64 values, even if they don't contain decimal points
+		// This handles cases like negative zero (-0.0) which formats as "-0" but should remain float
+		valueNode = utils.CreateFloatNode(val)
 		valueNode.Line = line
 	case reflect.Slice:
 		var rawNode yaml.Node
@@ -510,11 +508,9 @@ func (n *NodeBuilder) AddYAMLNode(parent *yaml.Node, entry *nodes.NodeEntry) *ya
 				if *b != 0 || entry.RenderZero {
 					formatFloat := strconv.FormatFloat(*b, 'f', -1, 64)
 
-					if *b == math.Trunc(*b) {
-						valueNode = utils.CreateIntNode(formatFloat)
-					} else {
-						valueNode = utils.CreateFloatNode(formatFloat)
-					}
+					// Always create float node for float64 values, even if they're whole numbers
+					// This handles cases like negative zero (-0.0) and ensures type consistency
+					valueNode = utils.CreateFloatNode(formatFloat)
 
 					valueNode.Line = line
 				}

datamodel/low/v2/responses_test.go

@@ -65,7 +65,7 @@ func TestResponses_Build_WrongType(t *testing.T) {
 
 func TestResponses_Hash(t *testing.T) {
 	// Clear any cached hashes to ensure clean test
-	index.ClearHashCache()
+	low.ClearHashCache()
 
 	yml := `default:
   description: I am a potato

utils/nodes.go

@@ -52,7 +52,6 @@ func CreateStringNode(str string) *yaml.Node {
 func CreateBoolNode(str string) *yaml.Node {
 	n := &yaml.Node{
 		Kind:  yaml.ScalarNode,
-		Tag:   "!!bool",
 		Value: str,
 	}
 	return n
@@ -61,7 +60,6 @@ func CreateBoolNode(str string) *yaml.Node {
 func CreateIntNode(str string) *yaml.Node {
 	n := &yaml.Node{
 		Kind:  yaml.ScalarNode,
-		Tag:   "!!int",
 		Value: str,
 	}
 	return n
@@ -79,7 +77,6 @@ func CreateEmptyScalarNode() *yaml.Node {
 func CreateFloatNode(str string) *yaml.Node {
 	n := &yaml.Node{
 		Kind:  yaml.ScalarNode,
-		Tag:   "!!float",
 		Value: str,
 	}
 	return n

utils/nodes_test.go

@@ -11,7 +11,7 @@ import (
 
 func TestCreateBoolNode(t *testing.T) {
 	b := CreateBoolNode("true")
-	assert.Equal(t, "!!bool", b.Tag)
+	assert.Equal(t, "", b.Tag) // No explicit tag - let YAML infer type
 	assert.Equal(t, "true", b.Value)
 }
 
@@ -35,13 +35,13 @@ func TestCreateEmptyScalarNode(t *testing.T) {
 
 func TestCreateFloatNode(t *testing.T) {
 	f := CreateFloatNode("3.14")
-	assert.Equal(t, "!!float", f.Tag)
+	assert.Equal(t, "", f.Tag) // No explicit tag - let YAML infer type
 	assert.Equal(t, "3.14", f.Value)
 }
 
 func TestCreateIntNode(t *testing.T) {
 	i := CreateIntNode("42")
-	assert.Equal(t, "!!int", i.Tag)
+	assert.Equal(t, "", i.Tag) // No explicit tag - let YAML infer type
 	assert.Equal(t, "42", i.Value)
 }
 
@@ -57,6 +57,6 @@ func TestCreateRefNode(t *testing.T) {
 
 func TestCreateYamlNode(t *testing.T) {
 	y := CreateYamlNode("foo")
-	assert.Equal(t, "!!str", y.Tag)
+	assert.Equal(t, "!!str", y.Tag) // Encode() sets appropriate tag
 	assert.Equal(t, "foo", y.Value)
 }