Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redundant bool return in Validation functions #28

Open
nickajacks1 opened this issue Oct 1, 2023 · 1 comment
Open

Redundant bool return in Validation functions #28

nickajacks1 opened this issue Oct 1, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@nickajacks1
Copy link
Contributor

The validation functions return both a bool and error(s).
It leads to simpler code to simply ignore the returned bool and check for len(errs) > 0 or err != nil
I suggest dropping the returned bool for the next breaking change unless there's some other purpose for it that I've missed
@daveshanley
Copy link
Member

Good idea, it does seem redundant as an API design.

@daveshanley daveshanley added the enhancement New feature or request label Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@daveshanley @nickajacks1