Clean up detekt errors.

Author: sshropshire

PayPalWebPayments/src/main/java/com/paypal/android/paypalwebpayments/PayPalWebStartCallback.kt

@@ -9,4 +9,4 @@ fun interface PayPalWebStartCallback {
      */
     @MainThread
     fun onPayPalWebStartResult(result: PayPalPresentAuthChallengeResult)
-}
+}

PayPalWebPayments/src/main/java/com/paypal/android/paypalwebpayments/UpdateClientConfigAPI.kt

@@ -39,7 +39,7 @@ internal class UpdateClientConfigAPI(
                 )
 
             is LoadRawResourceResult.Failure -> UpdateClientConfigResult.Failure(
-                PayPalSDKError(123, "TODO: implement")
+                PayPalSDKError(0, "TODO: implement")
             )
         }
     }
@@ -98,4 +98,4 @@ internal class UpdateClientConfigAPI(
             UpdateClientConfigResult.Failure(error)
         }
     }
-}
+}

PayPalWebPayments/src/main/java/com/paypal/android/paypalwebpayments/UpdateClientConfigResult.kt

@@ -4,7 +4,6 @@ import com.paypal.android.corepayments.PayPalSDKError
 
 sealed class UpdateClientConfigResult {
 
-    data class Success(val clientConfig: String): UpdateClientConfigResult()
-    data class Failure(val error: PayPalSDKError): UpdateClientConfigResult()
+    data class Success(val clientConfig: String) : UpdateClientConfigResult()
+    data class Failure(val error: PayPalSDKError) : UpdateClientConfigResult()
 }
-

PayPalWebPayments/src/test/java/com/paypal/android/paypalwebpayments/PayPalWebCheckoutClientUnitTest.kt

@@ -9,6 +9,7 @@ import io.mockk.mockk
 import io.mockk.verify
 import junit.framework.TestCase.assertSame
 import junit.framework.TestCase.assertTrue
+import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.ExperimentalCoroutinesApi
 import org.junit.Before
 import org.junit.Test
@@ -21,6 +22,7 @@ class PayPalWebCheckoutClientUnitTest {
 
     private val activity: FragmentActivity = mockk(relaxed = true)
     private val analytics = mockk<PayPalWebAnalytics>(relaxed = true)
+    private val updateClientConfigAPI = mockk<UpdateClientConfigAPI>(relaxed = true)
 
     private val intent = Intent()
 
@@ -30,7 +32,12 @@ class PayPalWebCheckoutClientUnitTest {
     @Before
     fun beforeEach() {
         payPalWebLauncher = mockk(relaxed = true)
-        sut = PayPalWebCheckoutClient(analytics, payPalWebLauncher)
+        sut = PayPalWebCheckoutClient(
+            analytics = analytics,
+            updateClientConfigAPI = updateClientConfigAPI,
+            payPalWebLauncher = payPalWebLauncher,
+            dispatcher = Dispatchers.Main
+        )
     }
 
     @Test