Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): bulk edit subfields #10035

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Conversation

jacobsfletch
Copy link
Member

@jacobsfletch jacobsfletch commented Dec 18, 2024

Fixes #10019. When bulk editing subfields, such as a field within a group, changes are not actually made because field paths are incorrect. This is because when opening the bulk edit drawer, fields are flattened into options for the field selector, but then remain flattened when thread into RenderFields. Once received, RenderFields attempts to build up its own field paths, but are never correct because they must did not pass through their parent's field in order to gain its "parent" path. The fix is to separate the reduce logic for the field selector from the fields to render, this way the fields sent to RenderFields can be traversed as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bulk editing of group field does not work
1 participant