Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Fake{Service}Request.php class. #24

Open
r-kujawa opened this issue Nov 24, 2023 · 0 comments
Open

Remove the Fake{Service}Request.php class. #24

r-kujawa opened this issue Nov 24, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@r-kujawa
Copy link
Contributor

Describe the solution you'd like. ✈️

  • Remove the Fake{Service}Request::class to simplify testing.
  • Find a way to make TEST_MODE mock the response without the Fake{Service}Request::class.

What problem will this solve? 🔥

Removes redundancy to the process because the request shall always remain the same, what is meant to be mocked is the response. This led developers to simply return a new instance of the Fake{Service}Response::class by passing it the data it had received. (Others would put the response mocking logic in the request contrapart, but that should also be considered "wrong", that logic should live within the Fake{Service}Response::class.

Which version(s) should this be pointed at?

1.x

@r-kujawa r-kujawa added the enhancement New feature or request label Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant