Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example will not compile for esp8266 NodeMCU using Arduino IDE v1.8.13 #6

Open
jponko opened this issue Nov 13, 2020 · 1 comment
Open
Assignees

Comments

@jponko
Copy link

jponko commented Nov 13, 2020

I had to modify lib ft857.h (line 107) prototype to:
void begin(long baudrate, SerialConfig mode); // custom baudrate and mode
and in ft857.cpp (line 55)
// Alternative initializer with a custom baudrate and mode
void ft857d::begin(long br, SerialConfig mode) {

Otherwise, compiler complains about int type not being type SerialConfig. This is only for the ESP8266. Not actually tested with a rig but at least now it will compile. I'm certain this has something to do with the esp8266 core because the original lib/example compiles for esp32 and UNO.

@stdevPavelmc
Copy link
Collaborator

Thank to spot that issue, I will be evaluating if create a conditional statement for the compiler or just change the variable at once.

@stdevPavelmc stdevPavelmc self-assigned this Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants