Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Understand why tests sometimes fail on windows #1412

Open
paulmillr opened this issue Jan 26, 2025 · 3 comments
Open

Understand why tests sometimes fail on windows #1412

paulmillr opened this issue Jan 26, 2025 · 3 comments
Labels

Comments

@paulmillr
Copy link
Owner

paulmillr commented Jan 26, 2025

Sometimes it passes, sometimes it doesn't. Feels random.

How can we make tests pass more often? Other platforms have higher pass rate.

https://github.com/paulmillr/chokidar/actions/runs/12972801273/job/36180667608

@43081j
Copy link
Collaborator

43081j commented Jan 26, 2025

i had another look at this recently and it seems to be the same test that fails at least

removing a directory recursively sometimes never emits the subdir's unlink event (i.e. the test expects an event for the dir being removed and the subdir below it)

but if you re-run, it usually passes. so it feels like a timing problem rather than the event just not being emitted. that, or windows just sometimes doesn't emit the events

@paulmillr
Copy link
Owner Author

Were you able to reproduce the issue locally instead of only github ci?

@43081j
Copy link
Collaborator

43081j commented Jan 26, 2025

i haven't. last i checked, it worked locally

i'll give it another go next time im on my windows machine though 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants