Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first trace event can be far off from navStart #46

Open
patrickhulce opened this issue May 1, 2017 · 0 comments
Open

first trace event can be far off from navStart #46

patrickhulce opened this issue May 1, 2017 · 0 comments

Comments

@patrickhulce
Copy link
Collaborator

patrickhulce commented May 1, 2017

discovered in GoogleChrome/lighthouse#2095

Traces can sometimes contain events that are far before navStart, even in more regular cases I've seen screenshots from the previous page linger in a trace of the new page that throws off the computation.

Two proposals with varying degrees of urgency:

  1. filter out screenshots before the user-provided timeOrigin opt (PR: #2114)
  2. consider defaulting startTs to the last occurrence of navigationStart for the root frame instead of the first event of the trace (Determine navigationStart as fallback timeOrigin #38)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant