Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tsc types #100

Open
paulirish opened this issue Jan 18, 2022 · 1 comment
Open

fix tsc types #100

paulirish opened this issue Jan 18, 2022 · 1 comment

Comments

@paulirish
Copy link
Owner

Back in #69 @brendankenny added some typechecking stuff

but it looks like its atrophied and there are now 25 errors.

it was never part of the test script or any ci stuff. shrug.

@brendankenny
Copy link
Collaborator

Some of this is typical easy tsc updating stuff, some of it is better checking of over-cleverness in the output that should probably have its implementation simplified (but may be a breaking change) and some of it is just older-style javascript that's difficult to type (e.g. object properties where it's hard to prove to the compiler that they won't be null by the time they're accessed).

Definitely doable, but it'll take some real code changes, not just types, so I'm giving up for now since it isn't a 10 minute job :) Anyone should feel free to take a stab at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants