Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui-builder lets you import icons from react-core #12

Open
jschuler opened this issue Dec 1, 2021 · 0 comments
Open

ui-builder lets you import icons from react-core #12

jschuler opened this issue Dec 1, 2021 · 0 comments

Comments

@jschuler
Copy link
Contributor

jschuler commented Dec 1, 2021

This should not be allowed but will render fine:

import { CubesIcon } from "@patternfly/react-core";

It should instead be:
import CubesIcon from "@patternfly/react-icons/dist/esm/icons/cubes-icon";
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jschuler