Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port over new features/fixes added to tackle2-ui's table-controls since this repo diverged from it #11

Open
mturley opened this issue Mar 18, 2024 · 0 comments
Assignees

Comments

@mturley
Copy link
Collaborator

mturley commented Mar 18, 2024

Because this hasn't been contributed to PatternFly yet, we haven't gotten around to replacing the original table-controls hooks in https://github.com/konveyor/tackle2-ui with it. Since we copied that code into this repo and started work to prepare it for PatternFly, more enhancements have been made to the original. If/when work resumes on this, we should look back at what has changed and decide whether to port over those new enhancements and any bug fixes.

Examples:

Note: the AttributeValueFilter introduced in forklift-console-plugin may also be a good candidate to use for inspiration for the future replacement of the legacy FilterToolbar, at least in part. https://github.com/kubev2v/forklift-console-plugin/blob/main/packages/common/src/components/FilterGroup/AttributeValueFilter.tsx

@ibolton336 ibolton336 self-assigned this Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants