Skip to content

Commit 521b65c

Browse files
authored
Merge pull request #7 from mturley/fix-selection
Fix memoization dependencies in useTrWithBatteries
2 parents 5b78bf9 + 7be841f commit 521b65c

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

packages/module/src/components/useTrWithBatteries.tsx

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -63,9 +63,6 @@ export const useTrWithBatteries = <
6363
const { isHeaderRow, onRowClick, builtInControls = true, children, ...otherProps } = props;
6464
const { item, rowIndex } = props as Partial<TrWithBatteriesBodyRowProps<TItem>>;
6565

66-
// eslint-disable-next-line no-console
67-
console.log({ isHeaderRow, item, numColumnsBeforeData, numColumnsAfterData });
68-
6966
return (
7067
<Tr
7168
{...propHelpers.getTrProps({ item, onRowClick })}
@@ -105,7 +102,14 @@ export const useTrWithBatteries = <
105102
);
106103
}
107104
),
108-
[activeItem.isEnabled, activeItem.activeItemId]
105+
[
106+
activeItem.isEnabled,
107+
activeItem.activeItemId,
108+
selection.isEnabled,
109+
selection.selectedItemIds,
110+
expansion.isEnabled,
111+
expansion.expandedCells
112+
]
109113
);
110114
TrWithBatteries.displayName = 'TrWithBatteries';
111115
return TrWithBatteries;

0 commit comments

Comments
 (0)