Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add create_attribute() #3

Open
webflo opened this issue Jan 10, 2017 · 5 comments
Open

Add create_attribute() #3

webflo opened this issue Jan 10, 2017 · 5 comments

Comments

@webflo
Copy link

webflo commented Jan 10, 2017

create_attribute() is a new twig function in Drupal core 8.3.x https://www.drupal.org/node/2818293

The Attribute class contains a lot of logic, i am not sure if we should copy it, trim it down or maybe add drupal/core as a composer dependency and use it directly?

@webflo
Copy link
Author

webflo commented Jan 10, 2017

Hmm aleksip/plugin-data-transform has the necessary classes already.

@aleksip
Copy link
Member

aleksip commented Jan 11, 2017

Ideally these issues will land some day:

Meanwhile Data Transform Plugin has the required classes and is already a dependency of Pattern Lab Twig Standard Edition for Drupal, so maybe it could be added as a dependency here too.

@romanovma
Copy link

are there any news on this one?

@waako
Copy link

waako commented Mar 19, 2018

There's PR #8 but that won't work, needs to be a function

@waako
Copy link

waako commented Mar 19, 2018

just added a create_attribute function in #10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants