Skip to content
This repository has been archived by the owner on Jun 27, 2019. It is now read-only.

Add enable/disable command for plugins #40

Open
raphaelokon opened this issue Mar 27, 2017 · 5 comments
Open

Add enable/disable command for plugins #40

raphaelokon opened this issue Mar 27, 2017 · 5 comments
Assignees
Milestone

Comments

@raphaelokon
Copy link
Contributor

Add following feature:

patternlab enable --plugins=plugin-name1, plugin-name2
patternlab disable --plugins=plugin-name1, plugin-name2

@raphaelokon
Copy link
Contributor Author

@bmuenzenmeyer Is this a viable feature and par with any core functionality?

@bmuenzenmeyer
Copy link
Member

bmuenzenmeyer commented Oct 11, 2017

yes,

as long as by enable and disable, you setting the value inside patternlab-config.json per guidance in the example here: https://github.com/pattern-lab/plugin-node-tab#configuration

this is how plugins will work in 3.X

@raphaelokon
Copy link
Contributor Author

Cool. I will implement it as per spec. Thanks

@raphaelokon
Copy link
Contributor Author

Just had a second look at it … isn't it a bit verbose to just expose plugin-related logic on the config?

This way either the plugin itself has to
(a) return its default configuration or
(b) the CLI has to map that somehow or
(c) the user has to manually add it to the PL config

I prefer (a) … as this unties the CLI and user from knowing the exact config. Also if different plugins or plugin versions require diff config this would be the easiest way to make sure having a non-breaking setup.

@raphaelokon
Copy link
Contributor Author

Actually: The more I think about this the more I feel we should handle it like babel—let the user enable/config plugins. I am closing this for now

@raphaelokon raphaelokon reopened this Oct 25, 2017
@raphaelokon raphaelokon added this to the v1.0.0 milestone Nov 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants