Skip to content
This repository has been archived by the owner on Jun 27, 2019. It is now read-only.

Starterkit installation fails for any starterkit without a package.json #15

Closed
6 tasks done
bmuenzenmeyer opened this issue Nov 22, 2016 · 9 comments
Closed
6 tasks done
Assignees

Comments

@raphaelokon raphaelokon self-assigned this Nov 23, 2016
@raphaelokon
Copy link
Contributor

@bmuenzenmeyer Can you explain on this one?

@bmuenzenmeyer
Copy link
Member Author

bmuenzenmeyer commented Jan 3, 2017

so we've had problems with npm/requiring starterkits in the past because their package.json files were missing a main entrypoint. this was a placeholder issue to make mention of all "official" starterkits that are still to be changed, like: https://github.com/pattern-lab/starterkit-mustache-bootstrap

i will turn this into a to-do list

@bmuenzenmeyer bmuenzenmeyer self-assigned this Jan 3, 2017
@raphaelokon
Copy link
Contributor

raphaelokon commented Jan 3, 2017

Oh I missed that, thanks! I will also try to think about a way to check for existence without a main in package.json

@raphaelokon
Copy link
Contributor

@bmuenzenmeyer I noticed that https://github.com/pattern-lab/starterkit-mustache-base cannot be installed via npm because no package.json

@bmuenzenmeyer
Copy link
Member Author

bmuenzenmeyer commented Feb 2, 2017

@raphaelokon all starterkits are done. feel free to retest that suite you showed me earlier and close this if it looks good

@raphaelokon
Copy link
Contributor

@bmuenzenmeyer Cheers for updating the starter kits

@raphaelokon
Copy link
Contributor

@bmuenzenmeyer
Copy link
Member Author

ugh. repushed. check again! off to bed for me

@raphaelokon
Copy link
Contributor

Enjoy! Works now – tests do pass. This will be fixed with the next bigger release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants