Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with UI Patterns (Drupal module) #38

Open
tanc opened this issue Jan 31, 2017 · 3 comments
Open

Incompatibility with UI Patterns (Drupal module) #38

tanc opened this issue Jan 31, 2017 · 3 comments

Comments

@tanc
Copy link

tanc commented Jan 31, 2017

The UI Patterns module allows patterns to be created and these can be associated with Pattern Lab based twig files. Due to Drupal's hard coded .html.twig extension in ThemeManager the UI Patterns module can't load a twig file from Pattern Lab which is missing the .html portion. This means that to load a twig file from Pattern Lab it has to be renamed to html.twig and all the supporting files also need to have html in them, for example: something.html.json. This is unpleasant. Is there a way of specifying the twig files in Pattern Lab to use html.twig while retaining the name of the supporting JSON, scss and md files without 'html' in the title?

See: nuvoleweb/ui_patterns/issues/49

@tanc
Copy link
Author

tanc commented Jan 31, 2017

It would appear that symfony/twig advocates the .html.twig file extension, so it would be great if this was supported in Pattern Lab.

https://symfony.com/doc/current/reference/configuration/twig.html

@tanc
Copy link
Author

tanc commented Mar 1, 2017

Any thoughts on this?

@ademarco
Copy link

@tanc UI Patterns will support any extensions via the use: property once this PR will get in: nuvoleweb/ui_patterns#84

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants