Skip to content
This repository has been archived by the owner on Dec 10, 2019. It is now read-only.

styleModifiers not reset? #15

Open
renestalder opened this issue Dec 18, 2017 · 1 comment
Open

styleModifiers not reset? #15

renestalder opened this issue Dec 18, 2017 · 1 comment

Comments

@renestalder
Copy link

renestalder commented Dec 18, 2017

I am using Pattern Lab Node v2.11.0 on Mac, using the webpack configuration.

Expected Behavior

When I include a pattern twice with different style modifiers, the patterns should be rendered with those style modifier differences.

Actual Behavior

When I include a pattern twice with different style modifiers, the pattern that is rendered first will overwrite all styleModifiers of the second pattern that is rendered.

Steps to Reproduce

Difficult to reproduce. What I have is a component called skew I call like this:

{{> components-skew }}

In a very different place, I call it like this.

{{> components-skew:inx-card__image-title|inx-card-skew--alpha|inx-card-skew--end(image: false) }}

As soon I add the second include, the first include will render with the exact same styleModifiers

@bmuenzenmeyer
Copy link
Member

Hey @renestalder

Thanks so much for the thorough report. I'll make sure to take a look at this soon - it was my belief I had passing unit tests for this scenario - so I am curious as to what's happening!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants